feat: permit default api context config to be used #4671
Merged
+50
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
bscholtes1A,
jimmarino,
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
ndr-brt
force-pushed
the
4669-enable-use-default-config
branch
from
231a3ac to
e97224e
Compare
jimmarino
approved these changes
Dec 13, 2024
wolf4ood
approved these changes
Dec 13, 2024
|
Yeah it's a bit convoluted and misleading on who actually adds the port mapping, that can happen in two places. Since now the pattern is to have always a module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove the
useDefaultContextattribute fromWebServiceSettings, because it's use was not clear and it didn't permit runtimes to start with default configuration.Why it does that
Briefly state why the change was necessary.
Further notes
namebecause it was used only for logging, and for thatcontextAliascan be used as welldefaultPathvalue in the form of/api/<context_alias>Linked Issue(s)
Closes #4669
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.